misc #330
Merged
misc #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notEthan
force-pushed
the
misc
branch
2 times, most recently
from
976981b
to
486e3e2
Compare
BootstrapSchema does not support jsi_schema_base_uri on the root node, so this can only come from the document, which is already in the fingerprint This reverts commit 5d6e5d3.
…on_modules the class is in the fingerprint and each schema_implementation_modules has a different class
…aModule::DescribesSchemaModule#schema_implementation_modules to that
…doesn't require overriding #to_s too this is mainly for Base and AttrStruct but doing it everywhere for consistency
…ted for PP::SingleLine
… #as_json everywhere
…cribe and test `let` it's not a problem here but it can be, better to have different names for these different scopes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.