Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typelike.as_json #19

Merged
merged 2 commits into from
Apr 23, 2018
Merged

Typelike.as_json #19

merged 2 commits into from
Apr 23, 2018

Conversation

notEthan
Copy link
Owner

I don't have anything required that adds #as_json everywhere, but I don't really want to, so I've added Scorpio::Typelike.as_json recursive method to do it.

@coveralls
Copy link

coveralls commented Apr 22, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 77

  • 17 of 26 (65.38%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 85.032%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/scorpio/resource_base.rb 0 1 0.0%
lib/scorpio/typelike_modules.rb 10 18 55.56%
Totals Coverage Status
Change from base Build 75: -0.4%
Covered Lines: 1210
Relevant Lines: 1423
💛 - Coveralls

@notEthan notEthan merged commit 5b098be into master Apr 23, 2018
notEthan added a commit that referenced this pull request Apr 23, 2018
@notEthan
Merge remote-tracking branches 'origin/typelike_as_json' and 'origin/…
dea0650 
…openapi_v3' into HEAD

#19 typelike_as_json
#20 openapi_v3
@notEthan notEthan deleted the typelike_as_json branch April 23, 2018 03:42
@notEthan notEthan restored the typelike_as_json branch April 24, 2018 03:58
@notEthan notEthan deleted the typelike_as_json branch April 24, 2018 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@notEthan @coveralls