Misc #25
Merged
Misc #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly strings are valid object keys in json.
if an object/hash key is specified as a number, as is valid in yaml, stringification is appropriate. the petstore, and probably many other openapi specs, use numbers instead of strings to key status code responses. we wish to identify the correct class_for_schema when that is the case.
before:
"responses" => #{<Scorpio::OpenAPI::V2::Responses Scorpio::JSON::HashNode fragment="#/paths/~1pet~1findByTags/get/responses">
200 => #{<Scorpio::JSON::HashNode fragment="#/paths/~1pet~1findByTags/get/responses/200">
after:
"responses" => #{<Scorpio::OpenAPI::V2::Responses Scorpio::JSON::HashNode fragment="#/paths/~1pet~1findByTags/get/responses">
200 => #{<Scorpio::OpenAPI::V2::Response Scorpio::JSON::HashNode fragment="#/paths/~1pet~1findByTags/get/responses/200">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
various relatively minor things too small for their own PRs