Fixing untrustable os.path.exists #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per https://stackoverflow.com/a/3112717/1067833, os.path.exists sometimes delivers a wrong value. These are corner cases, but mine is exactly one: I run xapian-haystack in a multiprocess environment (indexing and django server), on an LXC container, which has its mount probably mounted from an NFS server (I have no control/information over it). This corner case results the os.path.exists give `True` for one process and `False` for another, resulting in the exception I handle with this patch.
|
@notanumber, please merge this asap. |
|
Hey @karolyi I'm not actually the maintainer of this repo anymore, haven't been for many years in fact. You're looking for @jorgecarleitao At a glance, the commit seems good to me and all the tests still pass. Lets give @jorgecarleitao a bit to respond and if we don't hear from him I'll merge it. |
|
aight, thx. @jorgecarleitao, waiting for you eagerly. |
|
That indeed makes sense. Thanks @karolyi for the PR! |
|
great stuff. can you please create an actual release out of this? I'd like to deploy it into my environments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://stackoverflow.com/a/3112717/1067833,
os.path.exists sometimes delivers a wrong value. These are corner
cases, but mine is exactly one:
I run xapian-haystack in a multiprocess environment (indexing and
django server), on an LXC container, which has its mount probably
mounted from an NFS server (I have no control/information over it).
This corner case results the os.path.exists give
Truefor oneprocess and
Falsefor another, resulting in the exception Ihandle with this patch.