Fix PY2 error #180
Fix PY2 error #180
Conversation
|
@jorgecarleitao @notanumber are you still maintaining this project? I have some improvements, if you add me as a committer to this project, I'll add them. |
As per https://stackoverflow.com/a/3112717/1067833, os.path.exists sometimes delivers a wrong value. These are corner cases, but mine is exactly one: I run xapian-haystack in a multiprocess environment (indexing and django server), on an LXC container, which has its mount probably mounted from an NFS server (I have no control/information over it). This corner case results the os.path.exists give `True` for one process and `False` for another, resulting in the exception I handle with this patch.
|
Hey @karolyi Thanks for the pull requests. I haven't been the maintainer for this project for several years but if we don't hear from @jorgecarleitao within the next few days I'll go ahead and add you as a contributor. |
|
@notanumber thx, I'm working with xapian in one of my projects and I had to take a deep dive down the code. I have a lot updates, which will help it out in the long run. |
|
Hi @karolyi. Sorry for the delay, hadn't had much time for looking at it. Just reviewed and pushed your two changes to master. Thanks a lot for them!!! I haven't bumped the version because the build is failing for Django 1.8. This is a blocker for releasing a new version. |
|
I intend to fix that, and I have a couple of additions (stopwords, parameterizable weighing algorithms) too. If I you can add me as a contributor, we can pick up some speed too. |
|
I am very happy to know that you have a lot of fixes. Could you PR them? I will gladly review them. @notanumber, it is ok, I am here. Last 2 weeks have been a bit crazy, but things are coming back to normal. I will review the code from @karolyi before it is merged. |
Django < 1.11 is no longer supported by Django or Haystack Test against latest versions of Django 1.11, 2.0, 2.1. Test against python 2.7 (django 1.11 only), 3.5, 3.6, 3.7 (on xenial). Update xapian old-stable to 1.2.25, only for py27. Update xapian old-dev to 1.3.6, only for py27, py34. Update xapian stable to 1.4.9. xapian 1.3.6 included just to keep coverage numbers up. xapian 1.3.7 not included because it didn't build with install-xapian.sh.
This commit could use scrutiny.
check if user supplied version on command line and exit with message if they didn't
|
Most of the proposed changes have been merged with other pull requests. If you still find some things remaining to improve, please rebase or propose a new pull request. |
Last year I committed a change, which went red because of PY2 incompatibility. I hereby fix it, please merge ASAP.