Better coverage handling #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `coverage combine` with some more configuration in .coveragerc to merge our own paths with the paths we copy to when running coverage and tests in the django-haystack checkout. Also, print the simple coverage report in the Github Actions workflow for good measure. Fixes: notanumber#205
|
Also, sorry, not sorry, this will drop the coverage rating a smidge since it's now picking up test coverage of |
|
Looks like the tests files are included in the coverage. Shouldn't they be excluded? |
|
They've always been included in the coverage, so I didn't see fit to remove them. |
|
Having given this some more thought, no, they should be left in. It shows that they are being run. |
|
I don't want to fight on this. You did the job, so you decide, even if my personal opinion didn't change :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
coverage combinewith some more configuration in.coveragercto merge our own paths with the paths we copy to when running coverage
and tests in the django-haystack checkout.
Also, print the simple coverage report in the Github Actions workflow
for good measure.
Fixes: #205