Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions - expand test matrix #208

Merged
merged 1 commit into from Sep 26, 2021
Merged

Conversation

asedeno
Copy link
Collaborator

@asedeno asedeno commented Sep 25, 2021

Fixes: #207

Adding Python 3.7, 3.8, 3.9.
Adding Django 3.1, 3.2.

Reworking coveralls upload to handle parallel jobs with notification of completion.

@coveralls
Copy link

coveralls commented Sep 25, 2021

Coverage Status

Coverage remained the same at 97.495% when pulling 4a20032 on asedeno:coverage into ef1dc87 on notanumber:master.

@claudep
Copy link
Collaborator

claudep commented Sep 26, 2021

Looks great, thanks!
Now I know this is the traditional way of doing this. However in the spirit of greener practices, what would you think about testing only the minimal and maximal Python versions (3.6, 3.9) instead of the whole range?

@asedeno
Copy link
Collaborator Author

asedeno commented Sep 26, 2021

I think that would be fine. It is easy enough to change again in the future if we find we need additional test coverage.

@asedeno asedeno force-pushed the coverage branch 2 times, most recently from d902943 to a83d5d8 Compare September 26, 2021 16:26
@asedeno
Copy link
Collaborator Author

asedeno commented Sep 26, 2021

I've rebased this, and got rid of the python:3-slim container for the final coveralls task. ubuntu-latest has all the python3 we need, so container setup was wasteful.

@claudep
Copy link
Collaborator

claudep commented Sep 26, 2021

👍

@claudep claudep merged commit 14ca046 into notanumber:master Sep 26, 2021
@asedeno asedeno deleted the coverage branch September 27, 2021 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Actions - expand test matrix, unify coverage reports
3 participants