Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new exception to check equality of elements #47

Closed
abvg9 opened this issue Mar 27, 2020 · 3 comments · Fixed by #56
Closed

Add new exception to check equality of elements #47

abvg9 opened this issue Mar 27, 2020 · 3 comments · Fixed by #56
Assignees
Milestone

Comments

@abvg9
Copy link
Contributor

abvg9 commented Mar 27, 2020

In line 112 at the file src/com/ucm/dasi/catan/board/CatanBoard.java it's recommended to implement a runtime expcetion to handle this situation.

@abvg9 abvg9 changed the title Add new exception Add new exception to check equality of elements Mar 27, 2020
@notaphplover notaphplover self-assigned this Mar 28, 2020
@notaphplover
Copy link
Owner

@abvg9 InvalidBoardElementException seems to be the right one, should this exception be a RuntimeException?

Keep in mind that it's not mandatory to place a throws clause if a runtime exception is thrown, so it is still possible to place the throws clause when needed.

@notaphplover notaphplover added the needs more info Additional information is required label Mar 28, 2020
@notaphplover
Copy link
Owner

@abvg9 Try to reference code with GitHub references in base of a certain commit. For example, the line you are referencing is this one

@notaphplover notaphplover removed their assignment Mar 28, 2020
@abvg9
Copy link
Contributor Author

abvg9 commented Mar 28, 2020

@abvg9 InvalidBoardElementException seems to be the right one, should this exception be a RuntimeException?

Keep in mind that it's not mandatory to place a throws clause if a runtime exception is thrown, so it is still possible to place the throws clause when needed.

Okay, a runtime be said.

@notaphplover notaphplover removed the needs more info Additional information is required label Mar 28, 2020
@notaphplover notaphplover self-assigned this Mar 28, 2020
@notaphplover notaphplover added this to the Version 0.2.0 milestone Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants