Add gas check to make lint, fix unnecessary assignment #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuKeping
reviewed
Oct 24, 2016
| @@ -777,8 +777,7 @@ func (r *NotaryRepository) saveMetadata(ignoreSnapshot bool) error { | |||
| } | |||
|
|
|||
| for role, blob := range targetsToSave { | |||
| parentDir := filepath.Dir(role) | |||
| os.MkdirAll(parentDir, 0755) | |||
There was a problem hiding this comment.
Thanks for removing this!
HuKeping
reviewed
Oct 24, 2016
| @@ -777,8 +777,7 @@ func (r *NotaryRepository) saveMetadata(ignoreSnapshot bool) error { | |||
| } | |||
|
|
|||
| for role, blob := range targetsToSave { | |||
| parentDir := filepath.Dir(role) | |||
| os.MkdirAll(parentDir, 0755) | |||
| // If the parent directory does not exist, the cache.Set will create it | |||
There was a problem hiding this comment.
I wonder if this code comment is suitable for all the other metadata store implementations like memorystore and httpstore, they may need not to "create" the parent directory.
There was a problem hiding this comment.
Oh, it seems it will always init as FilesystemStore
There was a problem hiding this comment.
@HuKeping: yup this function is only used for clients saving local copies of the repo metadata to files on disk
riyazdf
changed the title
|
Tested it locally and it works great! Have rebased to the master. LGTM! |
HuKeping
approved these changes
Oct 26, 2016
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
Signed-off-by: Riyaz Faizullabhoy <riyaz.faizullabhoy@docker.com>
cyli
approved these changes
Oct 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the parent directory creation code from
client.gobecause it's already handled by the underlying cache.Also adds github.com/HewlettPackard/gas to the
make lintcheck, though it's a little bit hacky until securego/gosec#55 and securego/gosec#50 are resolved.