Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1148 incorrect markdown formatting #1149

Merged
merged 1 commit into from May 8, 2017
Merged

Fixes #1148 incorrect markdown formatting #1149

merged 1 commit into from May 8, 2017

Conversation

dingwilson
Copy link
Contributor

@dingwilson dingwilson commented May 5, 2017 •
edited

This fixes issue #1148

Sometimes GitHub is finicky with their markdown. Replacing the space fixes the markdown formatting issues.

Signed-off-by: Wilson Ding hello@wilsonding.com

@dingwilson
Fixes #1148 incorrect markdown formatting
4a9a862 
Signed-off-by: Wilson Ding <hello@wilsonding.com>
@docker-jenkins
Copy link

Can one of the admins verify this patch?

@cyli
Copy link
Contributor

cyli commented May 5, 2017

jenkins, please test this

@cyli
Copy link
Contributor

cyli commented May 5, 2017 •
edited

Thanks for fixing @dingwilson. LGTM on green.

endophage
endophage approved these changes May 8, 2017
View reviewed changes
Copy link
Contributor

@endophage endophage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks! @cyli given the scope of this change I'm OK merging without Jenkins coming back.

For accounting purposes: the codecov drop is just due to jenkins not responding.

@cyli
Copy link
Contributor

cyli commented May 8, 2017

@endophage 👍

@endophage endophage merged commit 2f3d6ed into notaryproject:master May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endophage endophage endophage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dingwilson @docker-jenkins @cyli @endophage