move mysql creds to compose env variables #76

jessfraz · 2015-07-17T13:35:26Z

closes #75

RichardScothern · 2015-07-17T16:57:10Z

cmd/notary-server/config.json

@@ -13,6 +13,6 @@
 	},
 	"storage": {
 		"backend": "mysql",
-		"db_url": "dockercondemo:dockercondemo@tcp(notarymysql:3306)/dockercondemo"
+		"db_url": "gordontheturtle:dockerrulez@tcp(notarymysql:3306)/development"


Should this line be referencing DB_USER et al?

i believe this is the right format user:password@

The format is fine, but the value are hard-coded. What I mean was the connection string should reference the env variables like : "${DB_USER}:${DB_PASS}@"

Will that work w cobra we whatever lib you use I'm not familiar

On Jul 17, 2015, at 11:59, Richard Scothern notifications@github.com wrote:

In cmd/notary-server/config.json:

@@ -13,6 +13,6 @@
},
"storage": {
"backend": "mysql",

"db_url": "dockercondemo:dockercondemo@tcp(notarymysql:3306)/dockercondemo"

"db_url": "gordontheturtle:dockerrulez@tcp(notarymysql:3306)/development"
The format is fine, but the value are hard-coded. What I mean was the connection string should reference the env variables like : "${DB_USER}:${DB_PASS}@"

—
Reply to this email directly or view it on GitHub.

I agree, this should reference the env variables, and they should be setup before this container runs.

does that work w cobra

ive never used that lib lol

I have no idea what Cobra is :)

This thing will be deployed with Ansible, until infra switches to docker-compose, so changes to this file are for now immaterial

oooooo i see, but in the container i see this being a problem maybe...

On Fri, Jul 17, 2015 at 1:06 PM, Richard Scothern notifications@github.com
wrote:

In cmd/notary-server/config.json
#76 (comment):

@@ -13,6 +13,6 @@
},
"storage": {
"backend": "mysql",

"db_url": "dockercondemo:dockercondemo@tcp(notarymysql:3306)/dockercondemo"

"db_url": "gordontheturtle:dockerrulez@tcp(notarymysql:3306)/development"

I have no idea what Cobra is :)

This thing will be deployed with Ansible, until infra switches to
docker-compose, so changes to this file are for now immaterial

—
Reply to this email directly or view it on GitHub
https://github.com/docker/notary/pull/76/files#r34926147.

ok ya i think it works

jessfraz · 2015-07-22T04:05:20Z

buellerrrrrr

jessfraz · 2015-07-27T17:12:58Z

hi!

RichardScothern · 2015-07-27T18:15:42Z

ping @endophage

thaJeztah · 2015-07-27T21:35:13Z

moby/moby#9176 (comment) 🙊👼

diogomonica · 2015-07-27T21:40:28Z

@thaJeztah the irony is not lost on us :)

The major difference is between doing it/condoning it for everyone using docker.

thaJeztah · 2015-07-27T21:43:46Z

@diogomonica I know, sorry, couldn't contain myself 😄

(change LGTM)

endophage · 2015-07-28T22:11:06Z

@RichardScothern Aaron is using a different compose file to deploy (he builds his own images from those we push to hub and deploys those). We want the files as they exist in the repo to be runnable locally so contributors can get up and running easily.

With that in mind, we probably need to revert the changes for ansible.

RichardScothern · 2015-07-28T22:37:12Z

@endophage I'm aware of this :) What do you want to do with this PR? 🍰

endophage · 2015-07-28T22:38:07Z

@RichardScothern you personally, nothing, just addressing your earlier comments.

jessfraz · 2015-07-28T22:38:58Z

so can i go back to what i had here originally ;) #76 (diff)

jessfraz · 2015-07-28T23:13:12Z

updated

thaJeztah · 2015-07-28T23:17:55Z

cmd/notary-server/config.json

@@ -12,6 +12,6 @@
 	},
 	"storage": {
 		"backend": "mysql",
-		"db_url": "dockercondemo:dockercondemo@tcp(notarymysql:3306)/dockercondemo"
+        "db_url": "gordontheturtle:dockerrulez@tcp(notarymysql:3306)/development"


Indentation looks off here

having a rough day over here haha

lol

On Tue, Jul 28, 2015 at 4:17 PM, Sebastiaan van Stijn <
notifications@github.com> wrote:

In cmd/notary-server/config.json
#76 (comment):

@@ -12,6 +12,6 @@
},
"storage": {
"backend": "mysql",

"db_url": "dockercondemo:dockercondemo@tcp(notarymysql:3306)/dockercondemo"

"db_url": "gordontheturtle:dockerrulez@tcp(notarymysql:3306)/development"

Indentation looks off here

—
Reply to this email directly or view it on GitHub
https://github.com/docker/notary/pull/76/files#r35713308.

I saw, no worries 👍

retabbed the whole thing, it was def mixed tabs and spaces :)

Thx, looks good now!

diogomonica · 2015-07-29T19:56:24Z

does docker-compose up work with this config? (as in, are we able to point notary to it and it works?)

jessfraz · 2015-07-29T20:02:04Z

yessir

jessfraz · 2015-07-29T20:02:14Z

but you may want to verify for yourself

Signed-off-by: Jessica Frazelle <princess@docker.com>

jessfraz · 2015-08-05T05:24:59Z

rebased..

jessfraz · 2015-08-11T01:24:55Z

come on people

endophage · 2015-08-11T17:23:26Z

Now that I've been playing with Ansible, there's basically no difference in whether we include the variables in a config file or as ENV variables, they will get defined in the same place then the reefer tool is responsible for either passing them to the process we run or placeholding them into a config . However for local dev, it seems much easier to include them in a config. Thoughts?

endophage · 2015-08-13T03:51:41Z

@jfrazelle going to close this as it'll be superceded by this PR #185

That PR will allow trust to take full control over deployments once I finish the integration.

client: Add optional custom User-Agent to HTTPRemoteStore

GordonTheTurtle added the status/0-needs-triage label Jul 17, 2015

RichardScothern reviewed Jul 17, 2015
View reviewed changes

jessfraz force-pushed the 75-move-mysql-creds-to-env-vars branch 2 times, most recently from cd58c9f to 3234fed Compare July 17, 2015 21:23

dmp42 added status/0-triage and removed status/0-needs-triage labels Jul 27, 2015

jessfraz force-pushed the 75-move-mysql-creds-to-env-vars branch from 3234fed to 610a64c Compare July 28, 2015 23:13

thaJeztah reviewed Jul 28, 2015
View reviewed changes

jessfraz force-pushed the 75-move-mysql-creds-to-env-vars branch from 610a64c to 17ef432 Compare July 28, 2015 23:24

jessfraz closed this Aug 1, 2015

jessfraz reopened this Aug 5, 2015

move mysql creds to compose env variables

554ea0e

Signed-off-by: Jessica Frazelle <princess@docker.com>

jessfraz force-pushed the 75-move-mysql-creds-to-env-vars branch from 17ef432 to 554ea0e Compare August 5, 2015 05:24

endophage closed this Aug 13, 2015

jessfraz deleted the 75-move-mysql-creds-to-env-vars branch September 3, 2015 21:26

endophage pushed a commit to endophage/notary that referenced this pull request Oct 27, 2015

Merge pull request notaryproject#76 from flynn/user-agent

1882ab4

client: Add optional custom User-Agent to HTTPRemoteStore

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move mysql creds to compose env variables #76

move mysql creds to compose env variables #76

jessfraz commented Jul 17, 2015

RichardScothern Jul 17, 2015

jessfraz Jul 17, 2015

RichardScothern Jul 17, 2015

jessfraz Jul 17, 2015

diogomonica Jul 17, 2015

jessfraz Jul 17, 2015

jessfraz Jul 17, 2015

RichardScothern Jul 17, 2015

jessfraz Jul 17, 2015

jessfraz Jul 17, 2015

jessfraz commented Jul 22, 2015

jessfraz commented Jul 27, 2015

RichardScothern commented Jul 27, 2015

thaJeztah commented Jul 27, 2015

diogomonica commented Jul 27, 2015

thaJeztah commented Jul 27, 2015

endophage commented Jul 28, 2015

RichardScothern commented Jul 28, 2015

endophage commented Jul 28, 2015

jessfraz commented Jul 28, 2015

jessfraz commented Jul 28, 2015

thaJeztah Jul 28, 2015

jessfraz Jul 28, 2015

jessfraz Jul 28, 2015

thaJeztah Jul 28, 2015

jessfraz Jul 28, 2015

thaJeztah Jul 28, 2015

diogomonica commented Jul 29, 2015

jessfraz commented Jul 29, 2015

jessfraz commented Jul 29, 2015

jessfraz commented Aug 5, 2015

jessfraz commented Aug 11, 2015

endophage commented Aug 11, 2015

endophage commented Aug 13, 2015

move mysql creds to compose env variables #76

move mysql creds to compose env variables #76

Conversation

jessfraz commented Jul 17, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jessfraz commented Jul 22, 2015

jessfraz commented Jul 27, 2015

RichardScothern commented Jul 27, 2015

thaJeztah commented Jul 27, 2015

diogomonica commented Jul 27, 2015

thaJeztah commented Jul 27, 2015

endophage commented Jul 28, 2015

RichardScothern commented Jul 28, 2015

endophage commented Jul 28, 2015

jessfraz commented Jul 28, 2015

jessfraz commented Jul 28, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

diogomonica commented Jul 29, 2015

jessfraz commented Jul 29, 2015

jessfraz commented Jul 29, 2015

jessfraz commented Aug 5, 2015

jessfraz commented Aug 11, 2015

endophage commented Aug 11, 2015

endophage commented Aug 13, 2015