Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add guide for managing plugins #219

Merged
merged 1 commit into from
Jun 21, 2023
Merged

add guide for managing plugins #219

merged 1 commit into from
Jun 21, 2023

Conversation

zr-msft
Copy link
Collaborator

@zr-msft zr-msft commented May 18, 2023 •
edited
Loading

fixes #225
fixes #185

@netlify
Copy link

netlify bot commented May 18, 2023 •
edited
Loading

✅ Deploy Preview for notarydev ready!

Name Link
🔨 Latest commit 8675112
🔍 Latest deploy log https://app.netlify.com/sites/notarydev/deploys/64823f447d3e1b00081d9dd7
😎 Deploy Preview https://deploy-preview-219--notarydev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

FeynmanZhou
FeynmanZhou previously approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to have this doc as an initial version for plugin management. For plugin uninstallation, we can add it in a follow-up PR.

@zr-msft zr-msft marked this pull request as draft May 19, 2023 20:36
@zr-msft
Copy link
Collaborator Author

zr-msft commented May 19, 2023

converting to draft to add uninstall and fix #225

@zr-msft zr-msft marked this pull request as ready for review May 19, 2023 20:48
@zr-msft
Copy link
Collaborator Author

zr-msft commented May 19, 2023

Added uninstall and security best practices

yizha1
yizha1 requested changes May 22, 2023
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zr-msft

content/en/docs/how-to/plugin-management.md Outdated Show resolved Hide resolved
content/en/docs/how-to/plugin-management.md Outdated Show resolved Hide resolved
toddysm
toddysm requested changes May 22, 2023
View reviewed changes
content/en/docs/how-to/plugin-management.md Outdated Show resolved Hide resolved
content/en/docs/how-to/plugin-management.md Outdated Show resolved Hide resolved
content/en/docs/how-to/plugin-management.md Outdated Show resolved Hide resolved
content/en/docs/how-to/plugin-management.md Show resolved Hide resolved
content/en/docs/how-to/plugin-management.md Outdated Show resolved Hide resolved
content/en/docs/how-to/plugin-management.md Outdated Show resolved Hide resolved
FeynmanZhou
FeynmanZhou reviewed May 25, 2023
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@byronchien byronchien mentioned this pull request May 25, 2023
Merged
@zr-msft zr-msft mentioned this pull request Jun 5, 2023
Closed
@zr-msft zr-msft requested review from toddysm and yizha1 June 7, 2023 16:46
iamsamirzon
iamsamirzon requested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@iamsamirzon iamsamirzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @priteshbandi

content/en/docs/how-to/plugin-management.md Outdated Show resolved Hide resolved
content/en/docs/how-to/plugin-management.md Outdated Show resolved Hide resolved
content/en/docs/how-to/plugin-management.md Show resolved Hide resolved
content/en/docs/how-to/plugin-management.md Show resolved Hide resolved
content/en/docs/how-to/plugin-management.md Show resolved Hide resolved
@zr-msft
add guide for managing plugins, including security best practices
8675112 
Signed-off-by: Zach Rhoads <zachary.rhoads@microsoft.com>
priteshbandi
priteshbandi approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zr-msft zr-msft requested a review from iamsamirzon June 13, 2023 15:37
FeynmanZhou
FeynmanZhou approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou
Copy link
Member

@toddysm @yizha1 @iamsamirzon Could you pls review it again as @zr-msft has resolved all comments above? Thanks!

yizha1
yizha1 approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iamsamirzon
iamsamirzon approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@iamsamirzon iamsamirzon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1
Copy link
Contributor

yizha1 commented Jun 17, 2023

@toddysm would you mind to take a look again, since the merging is blocked by "change requested".

@yizha1 yizha1 merged commit 63352ca into notaryproject:main Jun 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byronchien byronchien byronchien requested changes

@shizhMSFT shizhMSFT shizhMSFT left review comments

@iamsamirzon iamsamirzon iamsamirzon approved these changes

@yizha1 yizha1 yizha1 approved these changes

@toddysm toddysm toddysm approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@FeynmanZhou FeynmanZhou FeynmanZhou approved these changes

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document security best practices for downloading and installing plugins Document the security best practice
8 participants
@zr-msft @FeynmanZhou @yizha1 @toddysm @priteshbandi @byronchien @shizhMSFT @iamsamirzon