Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update registry authentication with cred store #279

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Update registry authentication with cred store #279

merged 1 commit into from
Jun 19, 2023

Conversation

zr-msft
Copy link
Collaborator

@zr-msft zr-msft commented Jun 7, 2023

fixes #276

@netlify
Copy link

netlify bot commented Jun 7, 2023 •
edited
Loading

✅ Deploy Preview for notarydev ready!

Name Link
🔨 Latest commit 8d378d3
🔍 Latest deploy log https://app.netlify.com/sites/notarydev/deploys/648c80700f16ad0008d92e0a
😎 Deploy Preview https://deploy-preview-279--notarydev.netlify.app/docs/how-to/registry-authentication
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zr-msft
Copy link
Collaborator Author

zr-msft commented Jun 7, 2023

@yizha1 left a question in the issue as well. reposting here:

can you provide the following config example snippets:

  1. notation config.json with a configured credStore.
  2. notation config.json with base64 username/pw stored

Current examples in the doc were my best guess.

@zr-msft zr-msft force-pushed the issue-276 branch 2 times, most recently from 6f021b1 to 3d3826d Compare June 12, 2023 16:11
@zr-msft
Update registry authentication with cred store
8d378d3 
Signed-off-by: Zach Rhoads <zachary.rhoads@microsoft.com>
@iamsamirzon
Copy link
Contributor

LGTM

yizha1
yizha1 approved these changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks @zr-msft

@yizha1 yizha1 merged commit d367414 into notaryproject:main Jun 19, 2023
6 checks passed
@zr-msft zr-msft deleted the issue-276 branch June 20, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT left review comments

@Two-Hearts Two-Hearts Two-Hearts left review comments

@iamsamirzon iamsamirzon iamsamirzon approved these changes

@yizha1 yizha1 yizha1 approved these changes

@FeynmanZhou FeynmanZhou Awaiting requested review from FeynmanZhou FeynmanZhou is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve registry authentication document with more information
5 participants
@zr-msft @iamsamirzon @shizhMSFT @yizha1 @Two-Hearts