Fix error message (#236)

Fix error message: Instead of printing bytes in error message convert them to string. Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
notaryproject · Dec 22, 2022 · c90d521 · c90d521
1 parent 6c88d3d
commit c90d521
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/plugin/plugin.go b/plugin/plugin.go
@@ -171,7 +171,7 @@ func run(ctx context.Context, pluginName string, pluginPath string, req proto.Re
 		if jsonErr != nil {
 			return proto.RequestError{
 				Code: proto.ErrorCodeGeneric,
-				Err:  fmt.Errorf("response is not in JSON format. error: %v stderr: %v", err, stderr)}
+				Err:  fmt.Errorf("response is not in JSON format. error: %v, stderr: %s", err, string(stderr))}
 		}
 		return re
 	}

diff --git a/plugin/plugin_test.go b/plugin/plugin_test.go
@@ -17,10 +17,10 @@ import (
 func TestGetMetadata(t *testing.T) {
 	t.Run("plugin error is in invalid json format", func(t *testing.T) {
 		exitErr := errors.New("unknown error")
-		stderr := []byte("{}")
+		stderr := []byte("sad")
 		wantErr := proto.RequestError{
 			Code: proto.ErrorCodeGeneric,
-			Err:  fmt.Errorf("response is not in JSON format. error: %v stderr: %v", exitErr, stderr)}
+			Err:  fmt.Errorf("response is not in JSON format. error: %v, stderr: %s", exitErr, string(stderr))}
 		plugin := CLIPlugin{}
 		executor = testCommander{stdout: nil, stderr: stderr, err: exitErr}
 		_, err := plugin.GetMetadata(context.Background(), &proto.GetMetadataRequest{})
@@ -47,7 +47,7 @@ func TestGetMetadata(t *testing.T) {
 		stderr := []byte("")
 		wantErr := proto.RequestError{
 			Code: proto.ErrorCodeGeneric,
-			Err:  fmt.Errorf("response is not in JSON format. error: %v stderr: %v", exitErr, stderr)}
+			Err:  fmt.Errorf("response is not in JSON format. error: %v, stderr: %s", exitErr, string(stderr))}
 		plugin := CLIPlugin{}
 		executor = testCommander{stdout: nil, stderr: stderr, err: exitErr}
 		_, err := plugin.GetMetadata(context.Background(), &proto.GetMetadataRequest{})