Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: update notation-core-go dependency #278

Merged
merged 1 commit into from Feb 16, 2023

Conversation

priteshbandi
Copy link
Contributor

Update notation-core-go dependency

@shizhMSFT shizhMSFT changed the title Update notation-core-go dependency bump: update notation-core-go dependency Feb 16, 2023
shizhMSFT
shizhMSFT previously approved these changes Feb 16, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
Copy link
Contributor

shizhMSFT commented Feb 16, 2023

We can remove this test

func TestSignWithTimestamp(t *testing.T) {

as we don't support timestamping in rc.2.

SteveLasker
SteveLasker previously approved these changes Feb 16, 2023
Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #278 (7a46c3c) into main (064887e) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   73.67%   73.67%           
=======================================
  Files          23       23           
  Lines        1994     1994           
=======================================
  Hits         1469     1469           
  Misses        425      425           
  Partials      100      100           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit de8b7dd into notaryproject:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants