Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates based on signing scheme update in notation-go-core #85

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

priteshbandi
Copy link
Contributor

@priteshbandi priteshbandi commented Jul 14, 2022

Updates to accommodate changes as part of notaryproject/notation-core-go#17

@dtzar dtzar added this to the alpha-3 milestone Jul 28, 2022
@yizha1 yizha1 assigned yizha1 and priteshbandi and unassigned yizha1 Aug 2, 2022
Copy link

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Pending fixes for build failure.

Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
@priteshbandi priteshbandi reopened this Aug 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #85 (660a881) into main (55fd020) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   72.12%   72.14%   +0.01%     
==========================================
  Files          36       36              
  Lines        2264     2265       +1     
==========================================
+ Hits         1633     1634       +1     
  Misses        506      506              
  Partials      125      125              
Impacted Files Coverage Δ
signature/plugin.go 68.50% <100.00%> (+0.15%) ⬆️
signature/signer.go 51.80% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gokarnm gokarnm merged commit f3bae83 into notaryproject:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Signing API Implementation
7 participants