-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Adding UTs and a bug fix #10
Conversation
Build is failing because of #11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add details about the bug and the fix to the PR description?
Done. Added it in PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage ? 70.91%
=======================================
Files ? 7
Lines ? 196
Branches ? 0
=======================================
Hits ? 139
Misses ? 54
Partials ? 3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
chore: Adding UTs and a bug fix.
Bug fixes:
generate-signature
command the plugin framework was trying to parse parse input asverify signature
command input.