Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy docker config is not supported #801

Closed
JeyJeyGao opened this issue Oct 12, 2023 · 0 comments · Fixed by #803
Closed

Legacy docker config is not supported #801

JeyJeyGao opened this issue Oct 12, 2023 · 0 comments · Fixed by #803
Labels
bug Something isn't working triage Need to triage

Comments

@JeyJeyGao
Copy link
Contributor

What is not working as expected?

Legacy docker config:

{
  "auths": {
    "https://notationreg.azurecr.io/": {
      "auth": "",
      "email": ""
    }
  }
}

The registry address may contain the https or http prefix and may have a / at the end. Docker CLI still supports the configuration file, so Notation also needs to support it.

What did you expect to happen?

Notation should use the credentials in the docker config with legacy format.

How can we reproduce it?

create a docker config:

{
  "auths": {
    "https://notationreg.azurecr.io/": {
      "auth": "",
      "email": ""
    }
  }
}

docker pull/push works, but Notation list/sign/verify/inspect doesn't work.

Describe your environment

Linux Ubuntu

What is the version of your Notation CLI or Notation Library?

V1.0.0

@JeyJeyGao JeyJeyGao added bug Something isn't working triage Need to triage labels Oct 12, 2023
priteshbandi pushed a commit that referenced this issue Oct 17, 2023
- oras-credential-go release note:
https://github.com/oras-project/oras-credentials-go/releases/tag/v0.3.1
- Resolves #801 

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Two-Hearts pushed a commit to Two-Hearts/notation that referenced this issue Nov 3, 2023
- oras-credential-go release note:
https://github.com/oras-project/oras-credentials-go/releases/tag/v0.3.1
- Resolves notaryproject#801 

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
shizhMSFT pushed a commit that referenced this issue Nov 3, 2023
- oras-credential-go release note:
https://github.com/oras-project/oras-credentials-go/releases/tag/v0.3.1
- Resolves #801 

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
shizhMSFT pushed a commit that referenced this issue Nov 3, 2023
- oras-credential-go release note:
https://github.com/oras-project/oras-credentials-go/releases/tag/v0.3.1
- Resolves #801 

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Need to triage
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant