spec: update cli verify spec for UX improvement #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Zha <yizha1@microsoft.com>
yizha1
added
UX
yizha1
requested review from
toddysm,
dtzar,
gokarnm,
priteshbandi,
shizhMSFT,
FeynmanZhou and
a team
Signed-off-by: Yi Zha <yizha1@microsoft.com>
|
I saw this PR has also improved the output of |
toddysm
approved these changes
Nov 8, 2022
toddysm
previously requested changes
Nov 11, 2022
Signed-off-by: Yi Zha <yizha1@microsoft.com>
|
Remove the updates for |
Codecov Report
@@ Coverage Diff @@
## main #440 +/- ##
==========================================
- Coverage 32.82% 32.48% -0.35%
==========================================
Files 25 25
Lines 1237 1250 +13
==========================================
Hits 406 406
- Misses 819 832 +13
Partials 12 12
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
|
@priteshbandi @toddysm New updates:
|
Signed-off-by: Yi Zha <yizha1@microsoft.com>
FeynmanZhou
reviewed
Nov 24, 2022
FeynmanZhou
reviewed
Nov 24, 2022
FeynmanZhou
reviewed
Nov 24, 2022
shizhMSFT
reviewed
Nov 25, 2022
specs/commandline/verify.md
Outdated
| | registryScopes | "*" | The policy applies to all the artifacts stored in any repositories. | | ||
| | signatureVerification | "level": "strict" | Signature verification is performed at strict level, which enforces all validations: `integrity`, `authenticity`, `authentic timestamp`, `expiry` and `revocation`.| | ||
| | signatureVerification | "level": "permissive" | The permissive level enforces most validations, but will only logs failures for `revocation` and `expiry`. | | ||
| | signatureVerification | "level": "audit" | The audit level only enforces signature `integrity` if a signature is present. Failure of all other validations are only logged. | |
There was a problem hiding this comment.
We don't have log implemented.
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
iamsamirzon
reviewed
Nov 28, 2022
iamsamirzon
reviewed
Nov 28, 2022
|
Suggested two enhancements |
iamsamirzon
approved these changes
Nov 29, 2022
Signed-off-by: Yi Zha <yizha1@microsoft.com>
shizhMSFT
approved these changes
Dec 1, 2022
specs/commandline/verify.md
Outdated
Comment on lines
14
to
15
| Resolved artifact tag '<tag>' to digest '<digest>' before verification. | ||
| Warning: The resolved digest may not point to the same signed artifact, since tags are mutable. |
There was a problem hiding this comment.
Note: These outputs will be in the form of logs.
Signed-off-by: Yi Zha <yizha1@microsoft.com>
yizha1
dismissed
toddysm’s stale review
Discussed with Toddy and looks good to him.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update cli verify spec for UX improvement
Signed-off-by: Yi Zha yizha1@microsoft.com