Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add verification failed log #469

Merged

Conversation

JeyJeyGao
Copy link
Contributor

Signed-off-by: Junjie Gao junjiegao@microsoft.com

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #469 (67da6d9) into main (63f4121) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
- Coverage   32.26%   32.23%   -0.03%     
==========================================
  Files          25       25              
  Lines        1336     1337       +1     
==========================================
  Hits          431      431              
- Misses        893      894       +1     
  Partials       12       12              
Impacted Files Coverage Δ
cmd/notation/verify.go 28.72% <0.00%> (-0.31%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickzheng200 patrickzheng200 added this to the RC-2 milestone Dec 6, 2022
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 7a947d5 into notaryproject:main Dec 7, 2022
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 5, 2023
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants