Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: added log to notation key and certificate commands #478

Merged
merged 11 commits into from Dec 20, 2022
Merged

update: added log to notation key and certificate commands #478

merged 11 commits into from Dec 20, 2022

Conversation

patrickzheng200
Copy link
Contributor

@patrickzheng200 patrickzheng200 commented Dec 9, 2022 •
edited

This PR adds log to notation key and certificate commands and updated the corresponding spec in key.md and certificate.md.

This PR is a part of resolving notaryproject/roadmap#71.

@Two-Hearts
added debug log for key command
3993215 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
added log for key command; updated key CLI spec
fb66ba8 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@patrickzheng200 patrickzheng200 self-assigned this Dec 9, 2022
@patrickzheng200 patrickzheng200 added this to the RC-2 milestone Dec 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022 •
edited

Codecov Report

Merging #478 (3140951) into main (e0c218a) will decrease coverage by 2.76%.
The diff coverage is 17.30%.

@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   32.33%   29.57%   -2.77%     
==========================================
  Files          25       26       +1     
  Lines        1336     1515     +179     
==========================================
+ Hits          432      448      +16     
- Misses        892     1050     +158     
- Partials       12       17       +5
Impacted Files Coverage Δ
cmd/notation/cert/add.go 29.09% <ø> (ø)
cmd/notation/cert/generateTest.go 16.52% <ø> (ø)
cmd/notation/cert/show.go 29.31% <12.50%> (-1.46%) ⬇️
cmd/notation/cert/list.go 28.04% <13.33%> (-2.09%) ⬇️
cmd/notation/key.go 22.88% <20.68%> (+0.09%) ⬆️
cmd/notation/logout.go 44.11% <0.00%> (-10.05%) ⬇️
cmd/notation/login.go 41.86% <0.00%> (-0.83%) ⬇️
cmd/notation/verify.go 27.00% <0.00%> (-0.28%) ⬇️
internal/envelope/envelope.go 100.00% <0.00%> (ø)
cmd/notation/internal/truststore/truststore.go 10.29% <0.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

JeyJeyGao
JeyJeyGao reviewed Dec 9, 2022
View reviewed changes
cmd/notation/key.go Outdated Show resolved Hide resolved
@Two-Hearts
updated per code review
34e4e82 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
JeyJeyGao approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts
added logs to notation cert command
c777cde 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
update
029696d 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@patrickzheng200 patrickzheng200 changed the title update: added log to notation key command update: added log to notation key and certificate commands Dec 12, 2022
@Two-Hearts
split
16066f8 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@patrickzheng200 patrickzheng200 added the UX User experience changes label Dec 13, 2022
shizhMSFT
shizhMSFT approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

cmd/notation/key.go Outdated Show resolved Hide resolved
cmd/notation/key.go Outdated Show resolved Hide resolved
cmd/notation/cert/show.go Outdated Show resolved Hide resolved
cmd/notation/cert/show.go Outdated Show resolved Hide resolved
@Two-Hearts
updated per code review
3140951 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@priteshbandi priteshbandi merged commit f83a48b into notaryproject:main Dec 20, 2022
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Dec 29, 2022
@Two-Hearts @vaninrao10
update: added log to notation key and certificate commands (notarypro…
6d82d00 
…ject#478)

This PR adds log to notation key and certificate commands and updated
the corresponding spec in key.md and certificate.md.

This PR is a part of resolving
notaryproject/roadmap#71.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Dec 29, 2022
@Two-Hearts @vaninrao10
update: added log to notation key and certificate commands (notarypro…
b7fc6a1 
…ject#478)

This PR adds log to notation key and certificate commands and updated
the corresponding spec in key.md and certificate.md.

This PR is a part of resolving
notaryproject/roadmap#71.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Dec 29, 2022
@Two-Hearts @vaninrao10
update: added log to notation key and certificate commands (notarypro…
3901e29 
…ject#478)

This PR adds log to notation key and certificate commands and updated
the corresponding spec in key.md and certificate.md.

This PR is a part of resolving
notaryproject/roadmap#71.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 3, 2023
@Two-Hearts @vaninrao10
update: added log to notation key and certificate commands (notarypro…
4291e91 
…ject#478)

This PR adds log to notation key and certificate commands and updated
the corresponding spec in key.md and certificate.md.

This PR is a part of resolving
notaryproject/roadmap#71.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 3, 2023
@Two-Hearts @vaninrao10
update: added log to notation key and certificate commands (notarypro…
814896a 
…ject#478)

This PR adds log to notation key and certificate commands and updated
the corresponding spec in key.md and certificate.md.

This PR is a part of resolving
notaryproject/roadmap#71.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 3, 2023
@Two-Hearts @vaninrao10
update: added log to notation key and certificate commands (notarypro…
e3f5b12 
…ject#478)

This PR adds log to notation key and certificate commands and updated
the corresponding spec in key.md and certificate.md.

This PR is a part of resolving
notaryproject/roadmap#71.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10 pushed a commit to vaninrao10/notation that referenced this pull request Jan 5, 2023
@Two-Hearts @vaninrao10
update: added log to notation key and certificate commands (notarypro…
0e9e366 
…ject#478)

This PR adds log to notation key and certificate commands and updated
the corresponding spec in key.md and certificate.md.

This PR is a part of resolving
notaryproject/roadmap#71.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

Assignees

@patrickzheng200 patrickzheng200

Labels
UX User experience changes
Projects
None yet
Milestone
RC-2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@patrickzheng200 @codecov-commenter @priteshbandi @shizhMSFT @JeyJeyGao @Two-Hearts