Fix: fixed notation cert command #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
patrickzheng200
requested review from
JeyJeyGao,
priteshbandi,
rgnote and
shizhMSFT
Codecov Report
@@ Coverage Diff @@
## main #483 +/- ##
=======================================
Coverage 32.14% 32.14%
=======================================
Files 25 25
Lines 1341 1341
=======================================
Hits 431 431
Misses 898 898
Partials 12 12 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
reviewed
Dec 19, 2022
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
vaninrao10
pushed a commit
to vaninrao10/notation
that referenced
this pull request
Dec 29, 2022
Before adding a file into the trust store using `notation cert add`, notation CLI would check if it's valid first. Only file containing valid certificate(s) will be added. Same rule applies to the `notation cert list` command. This PR fixes notaryproject#482. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10
pushed a commit
to vaninrao10/notation
that referenced
this pull request
Dec 29, 2022
Before adding a file into the trust store using `notation cert add`, notation CLI would check if it's valid first. Only file containing valid certificate(s) will be added. Same rule applies to the `notation cert list` command. This PR fixes notaryproject#482. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10
pushed a commit
to vaninrao10/notation
that referenced
this pull request
Dec 29, 2022
Before adding a file into the trust store using `notation cert add`, notation CLI would check if it's valid first. Only file containing valid certificate(s) will be added. Same rule applies to the `notation cert list` command. This PR fixes notaryproject#482. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10
pushed a commit
to vaninrao10/notation
that referenced
this pull request
Jan 3, 2023
Before adding a file into the trust store using `notation cert add`, notation CLI would check if it's valid first. Only file containing valid certificate(s) will be added. Same rule applies to the `notation cert list` command. This PR fixes notaryproject#482. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10
pushed a commit
to vaninrao10/notation
that referenced
this pull request
Jan 3, 2023
Before adding a file into the trust store using `notation cert add`, notation CLI would check if it's valid first. Only file containing valid certificate(s) will be added. Same rule applies to the `notation cert list` command. This PR fixes notaryproject#482. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10
pushed a commit
to vaninrao10/notation
that referenced
this pull request
Jan 3, 2023
Before adding a file into the trust store using `notation cert add`, notation CLI would check if it's valid first. Only file containing valid certificate(s) will be added. Same rule applies to the `notation cert list` command. This PR fixes notaryproject#482. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
vaninrao10
pushed a commit
to vaninrao10/notation
that referenced
this pull request
Jan 5, 2023
Before adding a file into the trust store using `notation cert add`, notation CLI would check if it's valid first. Only file containing valid certificate(s) will be added. Same rule applies to the `notation cert list` command. This PR fixes notaryproject#482. Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com> Signed-off-by: vaninrao10 <111005862+vaninrao10@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before adding a file into the trust store using
notation cert add, notation CLI would check if it's valid first. Only file containing valid certificate(s) will be added. Same rule applies to thenotation cert listcommand.This PR fixes #482.