feat: support OCI image manifest #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
patrickzheng200
requested review from
shizhMSFT and
JeyJeyGao
and removed request for
shizhMSFT
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #509 +/- ##
==========================================
+ Coverage 36.50% 36.81% +0.30%
==========================================
Files 29 30 +1
Lines 1504 1581 +77
==========================================
+ Hits 549 582 +33
- Misses 936 978 +42
- Partials 19 21 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
reviewed
Jan 17, 2023
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
priteshbandi
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Code LGTM with pending flag name discussion. For merge, I would suggest wait for that discussion to conclude and then based on it update the flag name.
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
|
The current build would fail due to dependency change in notation-go: notaryproject/notation-go#271 Please review notaryproject/notation-go#271 first. |
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
|
Dependency updated. PR ready to be reviewed/merged. |
JeyJeyGao
reviewed
Feb 8, 2023
shizhMSFT
reviewed
Feb 8, 2023
priteshbandi
reviewed
Feb 8, 2023
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
priteshbandi
approved these changes
Feb 8, 2023
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds OCI image manifest support to notation CLI according to this spec.
If using OCI artifact manifest to store signatures, notation requires the registry to support Referrers API as well.
Tested with [COSE, JWS] + [OCI artifact manifest, OCI image manifest] on ACR.
This PR would also resolve issue.