Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: e2e plugin test cases #510

Merged
merged 4 commits into from Feb 3, 2023
Merged

Conversation

JeyJeyGao
Copy link
Contributor

@JeyJeyGao JeyJeyGao commented Jan 16, 2023

  • Added e2e-plugin for e2e testing
  • Added plugin list, sign, verify test cases
  • with a few test cases set to skip (related issue)

Signed-off-by: Junjie Gao junjiegao@microsoft.com

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2023

Codecov Report

Merging #510 (384387d) into main (0e5f137) will increase coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   29.57%   29.61%   +0.03%     
==========================================
  Files          26       26              
  Lines        1515     1513       -2     
==========================================
  Hits          448      448              
+ Misses       1050     1048       -2     
  Partials       17       17              
Impacted Files Coverage Δ
cmd/notation/verify.go 27.27% <0.00%> (+0.27%) ⬆️
cmd/notation/sign.go 43.67% <0.00%> (+0.49%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

test/e2e/run.sh Outdated Show resolved Hide resolved
test/e2e/suite/common/common.go Show resolved Hide resolved
test/e2e/suite/plugin/verify.go Outdated Show resolved Hide resolved
test/e2e/plugin/verify_signature.go Outdated Show resolved Hide resolved
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
test/e2e/plugin/generate_envelope.go Outdated Show resolved Hide resolved
test/e2e/plugin/validator.go Outdated Show resolved Hide resolved
test/e2e/plugin/validator.go Outdated Show resolved Hide resolved
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 requested a review from rgnote February 2, 2023 01:16
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit d16aff1 into notaryproject:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants