Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit test for ioutil package #534

Merged
merged 1 commit into from Feb 3, 2023

Conversation

JeyJeyGao
Copy link
Contributor

#516
Signed-off-by: Junjie Gao junjiegao@microsoft.com

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #534 (ce04d2f) into main (375a701) will increase coverage by 1.93%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
+ Coverage   29.61%   31.54%   +1.93%     
==========================================
  Files          26       27       +1     
  Lines        1513     1566      +53     
==========================================
+ Hits          448      494      +46     
- Misses       1048     1053       +5     
- Partials       17       19       +2     
Impacted Files Coverage Δ
internal/osutil/file.go 86.79% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@patrickzheng200
Copy link
Contributor

Looks like this PR is just for unit test of a single file. I notice that PR 526 does the same thing, and both of the PRs share the same issue as well. Can we combine them into one PR?

@shizhMSFT
Copy link
Contributor

It is OK to have separated PRs.

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit f920dfe into notaryproject:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants