Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add documentation for unsupported x509 subjects #550

Closed
wants to merge 2 commits into from

Conversation

byronchien
Copy link
Contributor

Adds documentation for the cert subject check added in this PR.

Signed-off-by: Byron Chien chienb@amazon.com

Signed-off-by: Byron Chien <chienb@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023

Codecov Report

Merging #550 (738e005) into main (c47a452) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   36.20%   36.20%           
=======================================
  Files          30       30           
  Lines        1616     1616           
=======================================
  Hits          585      585           
  Misses       1010     1010           
  Partials       21       21           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shizhMSFT shizhMSFT changed the title Add documentation for unsupported x509 subjects doc: add documentation for unsupported x509 subjects Feb 13, 2023
Signed-off-by: Byron Chien <chienb@amazon.com>
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason of the limitation should not be directly called out in the doc but through security advisories.

@byronchien byronchien closed this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants