Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove short commands #552

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

priteshbandi
Copy link
Contributor

Fix commands short

  • -p is used for password so shouldn't use it for plugin
  • -c is not being used anywhere for plugin-config

Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #552 (813f2c3) into main (54b42cb) will not change coverage.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   36.34%   36.34%           
=======================================
  Files          30       30           
  Lines        1607     1607           
=======================================
  Hits          584      584           
  Misses       1002     1002           
  Partials       21       21           
Impacted Files Coverage Δ
cmd/notation/key.go 31.57% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title Fix commands short fix!: remove short commands Feb 16, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 85247a2 into notaryproject:main Feb 16, 2023
duffney pushed a commit to duffney/notation that referenced this pull request Mar 30, 2023
Fix commands short
* `-p` is used for password so shouldn't use it for plugin
* `-c` is not being used anywhere for `plugin-config`

Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
Signed-off-by: Josh Duffney <jduffney@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants