Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade version to v1.0.0-rc.2 #558

Merged
merged 1 commit into from Feb 17, 2023

Conversation

byronchien
Copy link
Contributor

Upgrading the notation version to v.1.0.0-rc.2

Signed-off-by: Byron Chien <byronc@ucla.edu>
@codecov-commenter
Copy link

Codecov Report

Merging #558 (a84c024) into main (d62fd58) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   34.36%   34.36%           
=======================================
  Files          32       32           
  Lines        1848     1848           
=======================================
  Hits          635      635           
  Misses       1192     1192           
  Partials       21       21           
Impacted Files Coverage Δ
internal/version/version.go 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamsamirzon
Copy link
Contributor

LGTM

@iamsamirzon iamsamirzon self-requested a review February 16, 2023 23:21
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title Upgrade version to v1.0.0-rc.2 chore: upgrade version to v1.0.0-rc.2 Feb 17, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title chore: upgrade version to v1.0.0-rc.2 build: upgrade version to v1.0.0-rc.2 Feb 17, 2023
@priteshbandi priteshbandi merged commit 5e2fa4a into notaryproject:main Feb 17, 2023
duffney pushed a commit to duffney/notation that referenced this pull request Mar 30, 2023
Upgrading the notation version to v.1.0.0-rc.2

Signed-off-by: Byron Chien <byronc@ucla.edu>
Signed-off-by: Josh Duffney <jduffney@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants