Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the CODEOWNERS format issue #564

Merged
merged 1 commit into from Feb 22, 2023

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Feb 21, 2023

Fix the format issue of CODEOWNERS file

  • The owners should be listed on one line
  • org-level owners are also added as sub-repo code owners

Signed-off-by: Yi Zha yizha1@microsoft.com

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Merging #564 (8062036) into main (5e2fa4a) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #564   +/-   ##
=======================================
  Coverage   34.36%   34.36%           
=======================================
  Files          32       32           
  Lines        1848     1848           
=======================================
  Hits          635      635           
  Misses       1192     1192           
  Partials       21       21           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao previously approved these changes Feb 21, 2023
shizhMSFT
shizhMSFT previously approved these changes Feb 21, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vaninrao10
vaninrao10 previously approved these changes Feb 21, 2023
Copy link
Contributor

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi previously approved these changes Feb 21, 2023
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FeynmanZhou
FeynmanZhou previously approved these changes Feb 21, 2023
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Yi Zha <yizha1@microsoft.com>
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vaninrao10 vaninrao10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddysm toddysm merged commit e47cf12 into notaryproject:main Feb 22, 2023
@yizha1 yizha1 deleted the fix_codeowners branch February 22, 2023 02:27
patrickzheng200 pushed a commit to patrickzheng200/notation that referenced this pull request Mar 1, 2023
Fix the format issue of CODEOWNERS file
- The owners should be listed on one line
- org-level owners are also added as sub-repo code owners

Signed-off-by: Yi Zha <yizha1@microsoft.com>

Signed-off-by: Yi Zha <yizha1@microsoft.com>

changed default to oci image manifest

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

update e2e

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

update e2e

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

update e2e

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@yizha1 yizha1 added the governance Community governnance label Mar 20, 2023
duffney pushed a commit to duffney/notation that referenced this pull request Mar 30, 2023
Fix the format issue of CODEOWNERS file
- The owners should be listed on one line
- org-level owners are also added as sub-repo code owners

Signed-off-by: Yi Zha <yizha1@microsoft.com>

Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Josh Duffney <jduffney@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
governance Community governnance
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

10 participants