Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update issue templates #594

Merged
merged 4 commits into from Jun 14, 2023
Merged

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Mar 22, 2023

Updates:

  • fix typo
  • remove notary v2 reference
  • remove unnecessary options

Signed-off-by: Yi Zha yizha1@microsoft.com

Signed-off-by: Yi Zha <yizha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Merging #594 (28427ef) into main (0391202) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #594   +/-   ##
=======================================
  Coverage   63.52%   63.52%           
=======================================
  Files          40       40           
  Lines        2237     2237           
=======================================
  Hits         1421     1421           
  Misses        695      695           
  Partials      121      121           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

FeynmanZhou
FeynmanZhou previously approved these changes Apr 4, 2023
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 added this to the 1.0.0 milestone Jun 11, 2023
@yizha1 yizha1 self-assigned this Jun 12, 2023
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 3215b60 into notaryproject:main Jun 14, 2023
4 checks passed
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants