Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump up versions and dependencies #643

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Apr 22, 2023

Update:

  • Bump up version to v1.0.0-rc.4
  • Update to notation-go v1.0.0-rc.4
  • Update to notation-core-go v1.0.0-rc.3

Signed-off-by: Yi Zha yizha1@microsoft.com

Signed-off-by: Yi Zha <yizha1@microsoft.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2023

Codecov Report

Merging #643 (05158c4) into main (6cd6555) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main     #643   +/-   ##
=======================================
  Coverage   33.16%   33.16%           
=======================================
  Files          32       32           
  Lines        2014     2014           
=======================================
  Hits          668      668           
  Misses       1324     1324           
  Partials       22       22           
Impacted Files Coverage Δ
internal/version/version.go 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@patrickzheng200 patrickzheng200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao previously approved these changes Apr 24, 2023
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gokarnm
Copy link
Contributor

gokarnm commented Apr 24, 2023

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Yi Zha <yizha1@microsoft.com>
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1 yizha1 merged commit 2e56dd4 into notaryproject:main Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants