update: align Notation with OCI specs #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erimental Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Two-Hearts
requested review from
gokarnm,
JeyJeyGao,
justincormack,
NiazFK,
patrickzheng200,
priteshbandi,
rgnote,
shizhMSFT and
SteveLasker
as code owners
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #663 +/- ##
==========================================
+ Coverage 33.33% 36.28% +2.95%
==========================================
Files 32 32
Lines 2019 1973 -46
==========================================
+ Hits 673 716 +43
+ Misses 1324 1229 -95
- Partials 22 28 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JeyJeyGao
reviewed
May 12, 2023
shizhMSFT
reviewed
May 12, 2023
sajayantony
reviewed
May 12, 2023
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: patrick <zongjunzheng@hotmail.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
sign,list,inspect, andverifycommands. When a user wants to try the Referrers API, they need to set bothNOTATION_EXPERIMENTAL=1AND--allow-referrers-api; if the Referrers API is not supported, fallback to the Referrers tag schema automatically. Otherwise, by default, Notation would use the Referrers tag schema in all commands deterministically.References:
https://github.com/opencontainers/distribution-spec/blob/v1.1.0-rc1/spec.md#listing-referrers
https://github.com/opencontainers/distribution-spec/blob/v1.1.0-rc1/spec.md#referrers-tag-schema
This PR has been tested and:
resolves #659
resolves #660