Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: generate e2e coverage profile #669

Merged
merged 1 commit into from
May 19, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented May 16, 2023

This PR uses the new Golang feature to generate coverage report for e2e tests.

For release tagging, the e2e test will be ran based on non-instrumented binary.

To run E2E with test coverage.txt generated locally, try

 make e2e-covdata

Resolves #667

@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Merging #669 (944ceb8) into main (5516199) will increase coverage by 27.01%.
The diff coverage is n/a.

❗ Current head 944ceb8 differs from pull request most recent head fecd054. Consider uploading reports for the commit fecd054 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##             main     #669       +/-   ##
===========================================
+ Coverage   33.33%   60.34%   +27.01%     
===========================================
  Files          32       42       +10     
  Lines        2019     2315      +296     
===========================================
+ Hits          673     1397      +724     
+ Misses       1324      811      -513     
- Partials       22      107       +85     

see 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@qweeah qweeah force-pushed the coverage-bak branch 2 times, most recently from ba9c86e to 0cbd1e8 Compare May 16, 2023 09:16
Makefile Show resolved Hide resolved
Signed-off-by: Billy Zha <jinzha1@microsoft.com>

try remove shell indication
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT
Copy link
Contributor

Pinging @priteshbandi for review

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit eb9e6ca into notaryproject:main May 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Low code coverage (33%) reported for notation main branch
5 participants