Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added digest check on resolve ref #689

Merged
merged 1 commit into from May 26, 2023

Conversation

Two-Hearts
Copy link
Contributor

This PR adds check on user input digest and resolved digest.

Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #689 (b3099f0) into main (d35d85c) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #689      +/-   ##
==========================================
- Coverage   63.94%   63.81%   -0.14%     
==========================================
  Files          40       40              
  Lines        2219     2222       +3     
==========================================
- Hits         1419     1418       -1     
- Misses        679      682       +3     
- Partials      121      122       +1     
Impacted Files Coverage Δ
cmd/notation/manifest.go 56.66% <0.00%> (-3.11%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit fcf72c7 into notaryproject:main May 26, 2023
4 checks passed
@Two-Hearts Two-Hearts deleted the fix branch May 26, 2023 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants