Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix the issue with getting credentials for docker.io #703

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix: fix the issue with getting credentials for docker.io #703

merged 1 commit into from
Jun 6, 2023

Conversation

Wwwsylvia
Copy link
Contributor

Fixes #697

@Wwwsylvia
fix getting credentials for docker.io
fe878f8 
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/notation/login.go Show resolved Hide resolved
priteshbandi
priteshbandi approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit 651412a into notaryproject:main Jun 6, 2023
4 checks passed
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
Merged
6 tasks
@Wwwsylvia Wwwsylvia deleted the fix_docker_io branch October 16, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Two-Hearts Two-Hearts Two-Hearts left review comments

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@JeyJeyGao JeyJeyGao Awaiting requested review from JeyJeyGao JeyJeyGao is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

notation login fails to detect existing credentials for docker.io
4 participants
@Wwwsylvia @priteshbandi @shizhMSFT @Two-Hearts