Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updating documentation with AWS Plugin support #711

Merged
merged 1 commit into from Jun 7, 2023

Conversation

priteshbandi
Copy link
Contributor

Updating documentation with AWS Plugin support

Signed-off-by: Pritesh Bandi <priteshbandi@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #711 (19a88b8) into main (651412a) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #711   +/-   ##
=======================================
  Coverage   63.77%   63.77%           
=======================================
  Files          40       40           
  Lines        2228     2228           
=======================================
  Hits         1421     1421           
  Misses        686      686           
  Partials      121      121           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@rgnote rgnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gokarnm gokarnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -22,8 +22,7 @@ Notation is a CLI project to add signatures as standard items in the registry ec
## Documents

- [Quick start: Sign and validate a container image](https://notaryproject.dev/docs/quickstart/)
- [Build, sign, and verify container images using Notary and Azure Key Vault](https://docs.microsoft.com/azure/container-registry/container-registry-tutorial-sign-build-push?wt.mc_id=azurelearn_inproduct_oss_notaryproject)

- Build, sign, and verify container images using Notation with [Azure Key Vault](https://docs.microsoft.com/azure/container-registry/container-registry-tutorial-sign-build-push?wt.mc_id=azurelearn_inproduct_oss_notaryproject) or [AWS Signer](https://docs.aws.amazon.com/signer/latest/developerguide/container-workflow.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priteshbandi You can also add the AWS Signer plugin to the Notary website after this PR is merged

@priteshbandi priteshbandi merged commit c9d3997 into notaryproject:main Jun 7, 2023
4 checks passed
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants