Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: bump oras-credentials-go v0.2.0 #717

Merged
merged 1 commit into from Jun 26, 2023
Merged

bump: bump oras-credentials-go v0.2.0 #717

merged 1 commit into from Jun 26, 2023

Conversation

wangxiaoxuan273
Copy link
Contributor

No description provided.

@shizhMSFT shizhMSFT changed the title bump: use oras-credentials-go' v0.2.0 bump: bump oras-credentials-go v0.2.0 Jun 20, 2023
go.mod Outdated
@@ -7,7 +7,7 @@ require (
github.com/notaryproject/notation-go v1.0.0-rc.6
github.com/opencontainers/go-digest v1.0.0
github.com/opencontainers/image-spec v1.1.0-rc3
github.com/oras-project/oras-credentials-go v0.1.2-0.20230609092929-bf5244c85f2a
github.com/oras-project/oras-credentials-go v0.1.2-0.20230619091306-26b25ce1e68a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.2.0 is just released. You may bump it to a versioned commit now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you sign your commits?

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
@wangxiaoxuan273
Copy link
Contributor Author

LGTM. Could you sign your commits?

I have signed my commits now. Please have a look.

@codecov-commenter
Copy link

Codecov Report

Merging #717 (163d38d) into main (3215b60) will decrease coverage by 16.93%.
The diff coverage is 0.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##             main     #717       +/-   ##
===========================================
- Coverage   63.52%   46.59%   -16.93%     
===========================================
  Files          40       40               
  Lines        2237     2232        -5     
===========================================
- Hits         1421     1040      -381     
- Misses        695     1105      +410     
+ Partials      121       87       -34     
Impacted Files Coverage Δ
cmd/notation/login.go 25.89% <0.00%> (+0.89%) ⬆️

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 371d7e3 into notaryproject:main Jun 26, 2023
4 checks passed
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants