Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Timestamp #978

Merged
merged 103 commits into from
Jul 22, 2024
Merged

feat: Timestamp #978

merged 103 commits into from
Jul 22, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Jun 27, 2024 •
edited
Loading

This PR adds timestamping support including corresponding E2E tests and spec changes.

Resolves #838

Example of sign with timestamping:

notation sign --timestamp-url <TSA_url> --timestamp-root-cert <TSA_root_certificate_filepath> <registry>/<repository>@<digest>

Example of verify with timestamping:

notation verify <registry>/<repository>@<digest>

@Two-Hearts
tsa
e04d7cd 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
resolved conflicts
b90399c 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
update
f249e7a 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
7d888dc
@Two-Hearts
update
3cbd3e5 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
resolve conflicts
9edc3c0 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
resolved conflicts
d2a86e4 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
95aad90
@Two-Hearts
resolved conflicts
68036b6 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
1622205
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
f14a98b
@Two-Hearts
update tspclient-go
e84f407 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
tsa
0e83d2f 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
update
a45c5dc 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
resolved conflicts
d7d7a1a 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
resolved conflicts
e73312f 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
c15b58d
@Two-Hearts
update
a851775 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
0bd76bc
@Two-Hearts
updated timestamp
eb0fcc9 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
7f60e9e
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
f7bd27c
@Two-Hearts
test
be15eb2 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
d4fa037
@Two-Hearts
update
177be5b 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
added at-timestamped-time in verification
64ffee5 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
added cli spec
b0c8b45 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
resolved conflicts
d9ae5aa 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
update
47872ad 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
f3a96c0
@Two-Hearts
Merge branch 'notaryproject:main' into tsa
f8c2d8e
@Two-Hearts
update
1b97540 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
shizhMSFT previously approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JeyJeyGao
JeyJeyGao previously approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi reviewed Jul 19, 2024
View reviewed changes
cmd/notation/sign.go Show resolved Hide resolved
cmd/notation/sign.go Outdated Show resolved Hide resolved
cmd/notation/sign.go Outdated Show resolved Hide resolved
cmd/notation/sign.go Outdated Show resolved Hide resolved
@Two-Hearts
updated per code review
49c8b81 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts Two-Hearts dismissed stale reviews from JeyJeyGao and shizhMSFT via 49c8b81 July 22, 2024 03:13
@Two-Hearts
fix E2E test
5c177c0 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
update
7c44b3e 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
update
6aafe34 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
updated E2E tests
26bc1d3 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
fixed E2E tests
7b996ec 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
fixed E2E tests
7aef357 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
fixed E2E tests
3196711 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
@Two-Hearts
updated dependencies
cafc2e1 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
JeyJeyGao
JeyJeyGao previously approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT reviewed Jul 22, 2024
View reviewed changes
internal/x509/cert.go Outdated Show resolved Hide resolved
@Two-Hearts
updated per code review
b05572b 
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

@Two-Hearts Two-Hearts mentioned this pull request Jul 22, 2024
Closed
@Two-Hearts Two-Hearts merged commit a034721 into notaryproject:main Jul 22, 2024
7 checks passed
@Two-Hearts Two-Hearts deleted the tsa branch July 22, 2024 23:50
@Two-Hearts Two-Hearts mentioned this pull request Jul 23, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yizha1 yizha1 yizha1 left review comments

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao left review comments

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@FeynmanZhou FeynmanZhou Awaiting requested review from FeynmanZhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Time-stamping
6 participants
@Two-Hearts @priteshbandi @yizha1 @shizhMSFT @FeynmanZhou @JeyJeyGao