Signature specification #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shizhMSFT
reviewed
Oct 12, 2021
|
Incorporates #93 |
SteveLasker
reviewed
Oct 12, 2021
SteveLasker
reviewed
Oct 13, 2021
SteveLasker
reviewed
Oct 13, 2021
SteveLasker
reviewed
Oct 13, 2021
SteveLasker
reviewed
Oct 13, 2021
SteveLasker
reviewed
Oct 13, 2021
SteveLasker
reviewed
Oct 13, 2021
SteveLasker
reviewed
Oct 13, 2021
sudo-bmitch
reviewed
Oct 13, 2021
|
Can we clarify what is being decided in this PR vs #93 |
gokarnm
reviewed
Oct 14, 2021
gokarnm
approved these changes
Oct 15, 2021
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Co-authored-by: Milind Gokarn <milind81@gmail.com> Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
shizhMSFT
reviewed
Oct 15, 2021
signature-specification.md
Outdated
| 3. `alg` header values for various signature algorithms: | ||
| | Signature Algorithm | "alg" Param Value | | ||
| | -------- | -------- | | ||
| | ECDSA on secp256r1 with SHA-256 | ES256 | |
There was a problem hiding this comment.
Can we have a more friendly name for secp256r1 from SECG? like P-256 from NIST?
Also, we need to provide a reference for readers. RFC 8422 Appendix A is a good one.
There was a problem hiding this comment.
Not all algos and curves are in NIST and that's the reason refrained from using NIST curves.
Added reference to RFC 8422 Appendix A for discovery.
|
@priteshbandi, looks like a few minor clarification items are still open. |
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
First draft of signature specification.
issues for future work
How is this PR different from #93?