Add support for user-defined signed attributes #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pritesh Bandi <pritesb@amazon.com>
gokarnm
approved these changes
Feb 18, 2022
SteveLasker
reviewed
Feb 18, 2022
| In Notary v2 annotations are being used to store signed attributes. | ||
| The annotations key prefix for Notary v2 use is not yet finalized. | ||
| See [issues-106](https://github.com/notaryproject/notaryproject/issues/106). | ||
| 1. Descriptor MAY contain `annotations` and if present it MUST follow the [annotation rules](https://github.com/opencontainers/image-spec/blob/main/annotations.md#rules). Notary v2 uses annotations for storing both Notary specific and user defined signed attributes. The prefix `org.cncf.notary` in annotation keys is reserved for use in Notary v2 and MUST NOT be used outside this specification. |
There was a problem hiding this comment.
annotation namespaces is pending, per #106
Suggest we leave this for consistency in this PR and resolve as we finalize 106.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is copy of #133 which got closed because I mistakenly deleted the branch.
Signed-off-by: Pritesh Bandi pritesb@amazon.com