Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario updates, incorporating scenarios, addressing PR feedback #15

Merged
merged 6 commits into from Aug 5, 2020
Merged

Scenario updates, incorporating scenarios, addressing PR feedback #15

merged 6 commits into from Aug 5, 2020

Conversation

SteveLasker
Copy link
Contributor

@SteveLasker SteveLasker commented Mar 5, 2020

Incorporates feedback from #12
Signed-off-by: Steve Lasker stevelasker@hotmail.com

Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
scenarios.md Outdated Show resolved Hide resolved
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
@SteveLasker
Copy link
Contributor Author

Can we get some 👀 on this so we can close these out?

@SteveLasker
Copy link
Contributor Author

@JustinCappos, can you ack that we've captured the scenarios portion

Copy link

@JustinCappos JustinCappos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document is really design heavy now. This covers a few cases but things like 7 only make sense in the context of a specific design, whereas 8 and 9 are much more general.

@SteveLasker
Copy link
Contributor Author

The document is really design heavy now. This covers a few cases but things like 7 only make sense in the context of a specific design, whereas 8 and 9 are much more general.

Are you referring to the scenario or implications? Do you have a proposed edit so we can merge?

@JustinCappos
Copy link

The document is really design heavy now. This covers a few cases but things like 7 only make sense in the context of a specific design, whereas 8 and 9 are much more general.

Are you referring to the scenario or implications? Do you have a proposed edit so we can merge?

It's more of a conceptual change to parts of the document. Some of the content like this feels like it is quite specific to the technologies and not the goals / scenarios. I'm just going to cut and paste a few example, but the conceptual difference is something I'm seeing throughout.

"The ACME Rockets environment enforces various company policies prior to any deployment, evaluating the content in the SBoM. The policy manager trusts the content within the SBoM is accurate, because they trust artifacts signed by wabbit-networks. The src content isn't evaluated at deployment time and can be left within the registry.

  1. Once the policy manager completes its validation, the deployment to the hosting environment is initiated. The SBoM is no longer needed, allowing the image to be deployed separately. A deploy artifact, referencing a specific configuration definition, may also be signed and saved, providing a historical record of what was deployed. The hosting environment also validates content is signed by trusted entities."

"The local environment has a policy by which it states the set of keys it accepts.

  • The signing and validation of artifacts does not require a registry. The local host can validate the signature using the public keys it accepts.
  • The key used for validation may be hosted in a registry, or other accessible location.
  • The lack of a registry name does not infer docker.io as a default registry."

"Users may reference the sha256 digest directly, or the artifact:tag. While tag locking is not part of the [OCI Distribution Spec][oci-distribution], various registries support this capability, allowing users to reference human readable tags, as opposed to long digests. Either reference is supported with Notary v2, however it's the unique manifest that is signed."

I don't really know if this should be moved to a separate document, if general text should replace it, or if I'm just keying in on things that I shouldn't.

Perhaps @justincormack should weigh in also and say whether what I'm objecting to makes any sense.

@SteveLasker
Copy link
Contributor Author

I don't really know if this should be moved to a separate document, if general text should replace it, or if I'm just keying in on things that I shouldn't.

@JustinCappos I think we're possibly seeing a view from different perspectives. There's a perspective that we need a signature solution to artifacts in a registry. A solution that can move with the artifact as it moves within and across registries. That does define a sandbox by which we're working within. In the call last week we discussed how we may need to tweak the sandbox, but we are scoping to storing signatures in a registry.
The work you've done in Tuf is about taking validation to a another confidence level. We've been talking about scope creep quite a bit, and how we can minimize that scope creep, working from a base that covers the scenarios and building upon it. For instance the generic SBoM references may refer to a Tuf implementation, a RedHat implementation or others.
Now I know @justincormack was thinking it might be more broad, and he was writing up something. This seems like the conversation we should be having. What is the scope of what we want to carve out here.

scenarios.md Show resolved Hide resolved
scenarios.md Outdated Show resolved Hide resolved
scenarios.md Show resolved Hide resolved
scenarios.md Show resolved Hide resolved
scenarios.md Outdated Show resolved Hide resolved
scenarios.md Outdated Show resolved Hide resolved
Comment on lines +238 to +239
1. The developer revokes their public key, indicating it's no longer valid.
1. The developer issues a new public key and re-signs their content.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgive me if this is covered elsewhere, I'm quite new here -- what are the implications, and verifications, needed for this new key authenticity? I don't see it in the implications below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving this open to see if we cover this in the key management working group.

Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
scenarios.md Outdated Show resolved Hide resolved
scenarios.md Outdated Show resolved Hide resolved
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
Copy link
Contributor Author

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tsaarni, great feedback I've incorporated into the latest update.

scenarios.md Outdated Show resolved Hide resolved
scenarios.md Show resolved Hide resolved
scenarios.md Show resolved Hide resolved
Comment on lines +238 to +239
1. The developer revokes their public key, indicating it's no longer valid.
1. The developer issues a new public key and re-signs their content.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaving this open to see if we cover this in the key management working group.

Steve Lasker added 2 commits August 4, 2020 17:59
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
@SteveLasker SteveLasker changed the title Scenario updates, incorporating scenarios from @JustinCappos Scenario updates, incorporating scenarios, addressing PR feedback Aug 5, 2020
@SteveLasker SteveLasker merged commit 2df3e28 into notaryproject:master Aug 5, 2020
NiazFK pushed a commit to NiazFK/requirements that referenced this pull request Jun 3, 2021
…taryproject#15)

Merging to have a base to iterate upon:
* Scenario updates, incorporating scenarios from @JustinCappos
* Spelling fix
* updated scenarios for multiple keys, added requirements
* Address PR feedback
* Fix typos
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
NiazFK pushed a commit to NiazFK/requirements that referenced this pull request Jun 8, 2021
…taryproject#15)

Merging to have a base to iterate upon:
* Scenario updates, incorporating scenarios from @JustinCappos
* Spelling fix
* updated scenarios for multiple keys, added requirements
* Address PR feedback
* Fix typos
Signed-off-by: Steve Lasker <stevelasker@hotmail.com>
@iamsamirzon iamsamirzon added this to All Close PRs in Test2Project Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Test2Project
All Close PRs
Development

Successfully merging this pull request may close these issues.

None yet

6 participants