Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix broken links, wrong artifactType and outdated ORAS usage #216

Merged
merged 2 commits into from Dec 22, 2022
Merged

doc: fix broken links, wrong artifactType and outdated ORAS usage #216

merged 2 commits into from Dec 22, 2022

Conversation

yizha1
Copy link
Contributor

@yizha1 yizha1 commented Dec 22, 2022

Updates:

  • Fix broken links
  • Fix wrong artifactType
  • Removing ORAS information

Signed-off-by: Yi Zha yizha1@microsoft.com

@yizha1
doc: fix spec links, artifact and oras related info
f7a4fdc 
Signed-off-by: Yi Zha <yizha1@microsoft.com>
@yizha1 yizha1 added this to the RC-2 milestone Dec 22, 2022
shizhMSFT
shizhMSFT approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

specs/signing-and-verification-workflow.md Outdated Show resolved Hide resolved
@yizha1
doc: update per comments
7d84d8d 
Signed-off-by: Yi Zha <yizha1@microsoft.com>
FeynmanZhou
FeynmanZhou approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 1d04262 into notaryproject:main Dec 22, 2022
@yizha1 yizha1 deleted the fix_specs branch December 23, 2022 02:34
@dasiths
Copy link

dasiths commented Feb 28, 2023 •
edited

Just mentioning a couple of important changes here so that search indexing will pick it up.

mediaType parameter changed from application/vnd.cncf.oras.artifact.manifest.v1+json to application/vnd.oci.artifact.manifest.v1+json

and

artifactType parameter changed from application/vnd.cncf.notary.v2.signature to application/vnd.cncf.notary.signature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@FeynmanZhou FeynmanZhou FeynmanZhou approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@iamsamirzon iamsamirzon Awaiting requested review from iamsamirzon

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Notary Project Planning Board
Status: Done
Milestone
RC-2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yizha1 @dasiths @priteshbandi @shizhMSFT @FeynmanZhou