Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security audit report #268

Merged
merged 1 commit into from Jul 8, 2023
Merged

Add security audit report #268

merged 1 commit into from Jul 8, 2023

Conversation

AdamKorcz
Copy link
Contributor

@AdamKorcz AdamKorcz mentioned this pull request Jul 5, 2023
Merged
@FeynmanZhou FeynmanZhou mentioned this pull request Jul 6, 2023
Merged
FeynmanZhou
FeynmanZhou approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@FeynmanZhou FeynmanZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou FeynmanZhou linked an issue Jul 6, 2023 that may be closed by this pull request
Start security audit for Notary #239
Closed
priteshbandi
priteshbandi approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou FeynmanZhou mentioned this pull request Jul 7, 2023
Closed
yizha1
yizha1 approved these changes Jul 8, 2023
View reviewed changes
Copy link
Contributor

@yizha1 yizha1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yizha1
Copy link
Contributor

yizha1 commented Jul 8, 2023

@AdamKorcz Thanks for adding the report. The commit needs to be signed. Please refer to signing commits for how-to.

@AdamKorcz
Add security audit report
285f1f0 
Adds the report for the audit conducted by Ada Logics

Signed-off-by: AdamKorcz <adam@adalogics.com>
@AdamKorcz
Copy link
Contributor Author

@yizha1 @FeynmanZhou The commit has been signed with gpg.

@priteshbandi priteshbandi merged commit 92b58df into notaryproject:main Jul 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddysm toddysm toddysm approved these changes

@priteshbandi priteshbandi priteshbandi approved these changes

@FeynmanZhou FeynmanZhou FeynmanZhou approved these changes

@iamsamirzon iamsamirzon iamsamirzon approved these changes

@yizha1 yizha1 yizha1 approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@justincormack justincormack Awaiting requested review from justincormack

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start security audit for Notary
6 participants
@AdamKorcz @yizha1 @toddysm @priteshbandi @FeynmanZhou @iamsamirzon