Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ber to der convertor #11

Merged
merged 8 commits into from
Jan 31, 2024
Merged

Conversation

JeyJeyGao
Copy link
Contributor

Signed-off-by: Junjie Gao junjiegao@microsoft.com

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Partial review

cms/encoding/ber/ber.go Outdated Show resolved Hide resolved
cms/encoding/ber/ber.go Outdated Show resolved Hide resolved
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@JeyJeyGao JeyJeyGao requested a review from a team as a code owner January 18, 2024 02:13
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Partial review; ber.go has not been reviewed yet.

internal/encoding/asn1/ber/common.go Outdated Show resolved Hide resolved
internal/encoding/asn1/ber/common.go Outdated Show resolved Hide resolved
internal/encoding/asn1/ber/common.go Outdated Show resolved Hide resolved
internal/encoding/asn1/ber/common.go Outdated Show resolved Hide resolved
internal/encoding/asn1/ber/ber.go Show resolved Hide resolved
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
internal/encoding/asn1/ber/ber.go Outdated Show resolved Hide resolved
internal/encoding/asn1/ber/ber.go Outdated Show resolved Hide resolved
internal/encoding/asn1/ber/common.go Outdated Show resolved Hide resolved
internal/encoding/asn1/ber/common.go Outdated Show resolved Hide resolved
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Two-Hearts
Two-Hearts previously approved these changes Jan 19, 2024
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as all my review comments were resolved in PR 176: notaryproject/notation-core-go#176

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Two-Hearts
Two-Hearts previously approved these changes Jan 19, 2024
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as all my review comments were resolved in PR 176: notaryproject/notation-core-go#176

Copy link

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 2862807 into notaryproject:main Jan 31, 2024
4 checks passed
JeyJeyGao added a commit to JeyJeyGao/tspclient-go that referenced this pull request Jan 31, 2024
commit 2862807
Author: Junjie Gao <junjiegao@microsoft.com>
Date:   Wed Jan 31 15:21:55 2024 +0800

    feat: ber to der convertor (notaryproject#11)

    Signed-off-by: Junjie Gao <junjiegao@microsoft.com>

commit a373599
Author: Patrick Zheng <patrickzheng@microsoft.com>
Date:   Mon Jan 22 16:37:33 2024 +0800

    ci: add MAKEFILE and build workflow to the repo (notaryproject#19)

    Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

commit 6fa8c7f
Author: Patrick Zheng <patrickzheng@microsoft.com>
Date:   Mon Jan 22 16:36:50 2024 +0800

    ci: add dependabot (notaryproject#16)

    Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

commit bdae447
Author: Patrick Zheng <patrickzheng@microsoft.com>
Date:   Mon Jan 22 16:36:24 2024 +0800

    ci: add code coverage check (notaryproject#15)

    Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

commit 4cc6846
Author: Patrick Zheng <patrickzheng@microsoft.com>
Date:   Mon Jan 22 16:35:54 2024 +0800

    ci: add license checker to the repo (notaryproject#13)

    Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>

commit a27c098
Author: Yi Zha <yizha1@microsoft.com>
Date:   Thu Jan 18 10:02:22 2024 +0800

    chore: add CODEOWNERS and MAINTAINERS file (notaryproject#12)

    Resolve notaryproject#2

    Signed-off-by: Yi Zha <yizha1@microsoft.com>

Signed-off-by: Junjie Gao <junjiegao@microsoft.com>
@Two-Hearts Two-Hearts mentioned this pull request Jul 9, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants