Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add searching #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add searching #1

wants to merge 1 commit into from

Conversation

notbadcodecom
Copy link
Owner

  • для поиска по папкам использовал ForkJoinPool;
  • для поиска слов использовал ParallelStream;
  • для поиска в google использовал CompletableFuture.

kincajou
kincajou reviewed Feb 8, 2023
View reviewed changes
parallelism/src/main/java/ru/hh/school/homework/search/file/ForkJionFilesSearcher.java
import java.util.List;
import java.util.concurrent.ForkJoinPool;

public class ForkJionFilesSearcher implements FileSearcher {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jion -> Join

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, спасибо.

@kincajou
Copy link

kincajou commented Feb 8, 2023

так, ну тут у нас очевидная пятерка
с первого раза сделал все как нужно
придраться не к чему :-)

пара коментов:

  • к поиску в гугле можно прикрутить кеш - сильно ускорит
  • чтобы не возиться с замерами таймингов руками я бы какойнить com.google.common.base.Stopwatch заюзал

в остальном супер, надеюсь было полезно :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kincajou kincajou kincajou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@notbadcodecom @kincajou