getCall is not working correctly

[jonathan-benn]

spy = sinon.spy()
spy(1)
spy(2)
spy.getCall(0)
spy.getCall(1) # fails with "IndexError: The call queue only contains 1 calls"

I think that getCall is not actually returning a call, but rather returning a queued spy/stub. Every time a new spy or stub is created, a new item is added to the queue, and this new item is what's returned by getCall. What is supposed to happen is that getCall should return the execution of a particular spy or stub. Perhaps args_list should be used by getCall?

[note35]

Right, checking args_list and kwargs_list in getCall() will make it work properly. The default return of any getCall(n) will be None.

There is another thing need to consider, there is no class Call in current implementation, I considered to not implement this because of making code simple. All features of spy.call are implemented in Wrapper.py now.

For OOD, you might consider to implement an interface for Wrapper called Call. For sure this is an option.

[jonathan-benn]

Over the long term, I think that creating a new class Call is the right direction

[note35]

Hi,
I have created a gitter here. About creating class Call, we can discuss in there.

By the way, I highly recommend you to fork a new branch and adding your changes in there. With this way, I can also read your commits and code changes. It will make our discussion clear. Later you can rebase your changes into master. 😄