Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redshift vs view definitions #128

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

jlrobins
Copy link
Contributor

@jlrobins jlrobins commented Jul 14, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Unit tests are present
  • Have you validated this change locally?

Summary of Changes

  • Redshift dialect returns text() objects from get_view_definition(), surprising things and preventing encapsulation into pydantic message expecting exactly str. So capture and expliclty str() downgrade.

What is the Current Behavior?

  • Cannot introspect Redshift databases that have views.

What is the New Behavior?

  • Introspection succeeds.

@jlrobins
Copy link
Contributor Author

Sketch in-notebook of the fix is over at https://app.noteable-integration.us/f/428e8a16-4997-4894-ad88-727f8ec77f9c/Redshift.ipynb . W/o the hooking in of custom get_view_definition(), the \introspect in that notebook fails.

@jlrobins jlrobins merged commit b7ea1e8 into main Jul 14, 2023
2 checks passed
@jlrobins jlrobins deleted the ENG-6250-redshift-vs-view-introspection branch July 14, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants