Skip to content

Commit

Permalink
Change folder location of auto-completion for zipped package
Browse files Browse the repository at this point in the history
  • Loading branch information
@donho
donho committed Dec 23, 2018
1 parent d6f5b7b commit 90c724a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions PowerEditor/installer/packageAll.bat
View file
Expand Up @@ -126,12 +126,12 @@ mkdir .\zipped.package.release
mkdir .\zipped.package.release\updater
mkdir .\zipped.package.release\localization
mkdir .\zipped.package.release\themes
mkdir .\zipped.package.release\autoCompletion
mkdir .\zipped.package.release\plugins
mkdir .\zipped.package.release\plugins\NppExport
mkdir .\zipped.package.release\plugins\mimeTools
mkdir .\zipped.package.release\plugins\NppConverter
mkdir .\zipped.package.release\plugins\DSpellCheck
mkdir .\zipped.package.release\plugins\APIs
mkdir .\zipped.package.release\plugins\Config
mkdir .\zipped.package.release\plugins\doc

Expand All @@ -143,11 +143,11 @@ mkdir .\zipped.package.release64
mkdir .\zipped.package.release64\updater
mkdir .\zipped.package.release64\localization
mkdir .\zipped.package.release64\themes
mkdir .\zipped.package.release64\autoCompletion
mkdir .\zipped.package.release64\plugins
mkdir .\zipped.package.release64\plugins\mimeTools
mkdir .\zipped.package.release64\plugins\NppConverter
mkdir .\zipped.package.release64\plugins\DSpellCheck
mkdir .\zipped.package.release64\plugins\APIs
mkdir .\zipped.package.release64\plugins\Config
mkdir .\zipped.package.release64\plugins\doc

Expand Down Expand Up @@ -243,9 +243,9 @@ copy /Y ".\nativeLang\*.xml" .\zipped.package.release64\localization\
If ErrorLevel 1 goto End

rem files API: Copy all files into Notepad++ 32-bit/64-bit package folders
copy /Y ".\APIs\*.xml" .\zipped.package.release\plugins\APIs\
copy /Y ".\APIs\*.xml" .\zipped.package.release\autoCompletion\
If ErrorLevel 1 goto End
copy /Y ".\APIs\*.xml" .\zipped.package.release64\plugins\APIs\
copy /Y ".\APIs\*.xml" .\zipped.package.release64\autoCompletion\
If ErrorLevel 1 goto End

rem theme: Copy all files into Notepad++ 32-bit/64-bit package folders
Expand Down

4 comments on commit 90c724a

@dinkumoil
Copy link
Contributor

@dinkumoil dinkumoil commented on 90c724a Dec 23, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a discussion concerning the APIs folder, see this posting and the following: https://notepad-plus-plus.org/community/topic/16790/notepad-7-6-1/8

If you want to change the location of this directory, it would be the best to change it to %ProgramData%\Notepad++\autoCompletion because there are plugins which are actually lexers. This way a future version of Plugins Admin could install this type of plugins as well.

I'm aware of 3 plugins, which currently store files to the APIs directory, WLangLexer, MaxScriptExplorer and UDL AutoCad.

@donho
Copy link
Member Author

@donho donho commented on 90c724a Dec 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinkumoil If Notepad++ is installed in Program Files, how plugins can write into its sub-folder?

@MetaChuh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinkumoil
as those 3 plugins have to be rewritten anyways due to the path changes, is there any specific reason to use %programdata% instead of $instdir ?
as far as i can see the compatibility of those plugins will be broken anyways, regardless of using %programdata% or $instdir.
and the plugin authors can always put their own additional lexer files in their own plugins sub folder and use them from there, using the official autocompletion files as read only from $INSTDIR\autoCompletion if they need them

@dinkumoil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donho @MetaChuh

If Notepad++ is installed in Program Files, how plugins can write into its sub-folder?

I was talking about %ProgramData% directory. ;-)

The plugins which want to store files in the autoCompletion directory have to be rewritten of course.

See also my comment in the community forum.

Please sign in to comment.