Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut mapper / Macros tab shows garbled/cropped text in status area #10358

Closed
artie-finkelstein opened this issue Aug 9, 2021 · 8 comments
Assignees
Labels

Comments

@artie-finkelstein
Copy link

Description of the Issue

Text displayed in the "Shortcut mapper" status area (e.g., "No shortcut conflicts for this item.") only shows a few of the pixels of the bottom of the string but with most of the string shifted up past the top of the proper display area.

Steps to Reproduce the Issue

  1. Npp 8.13rc or Npp 8.13rc2
  2. click on \Macro\Modify Shortcut/Delete Macro...

Expected Behavior

I expected to be able to read the text (see attached file "macro-good status.png")

Actual Behavior

I got the results show in the attached file "macro-bad status.png

Debug Information

Notepad++ v8.1.3 (32-bit)
Build time : Aug 8 2021 - 13:17:47
Path : C:\Programs\Notepad++\notepad++_8.13rc2.exe
Command Line :
Admin mode : ON
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 7 Professional (64-bit)
OS Build : 7601.0
Current ANSI codepage : 1252
Plugins : none

This cropping does not occur with 8.12 or earlier releases. It's only visible under 8.13rc & 8.13rc2 and shows up when '\Macro\Modify Shortcut/Delete Macro...' is used to initially display the 'Shortcut mapper' menu. This cropping can also show up on the 'Plugin commands' tab, and may then show up on other tabs if they are selected after 'Plugin commands'. (For this portion of testing I obviously had plugins enabled.)

Plugins : BetterMultiSelection.dll ColumnTools.dll CustomLineNumbers.dll DSpellCheck.dll Explorer.dll ExtSettings.dll FallingBricks.dll FingerText.dll Linefilter3.dll LuaScript.dll MarkdownViewerPlusPlus.dll MenuIcons.dll mimeTools.dll NavigateTo.dll NppCalc.dll NppColumnSort.dll NppEditorConfig.dll NppEventExec.dll NppExec.dll NppFavorites.dll NppHorizontalRuler.dll NPPJSONViewer.dll NppJumpList.dll NppMenuSearch.dll NppQCP.dll NppSnippets.dll NppTextFX.dll NppTextViz.dll NppUISpy.dll OpenFileInFolders.dll pork2sausage.dll PreviewHTML.dll PythonScript.dll QuickText.dll selectNLaunch.dll ZoomDisabler.dll _CustomizeToolbar.dll 

The 'Scintilla commands' and 'Run commands' tabs seem to be immune to this cropping. If 'Main menu' is infected it can't be removed short of closing the entire dialog box, whereas 'Macros' can usually be temporarily "uninfected" by selecting 'Run commands' before going back to 'Macros'. The 'Main menu' tab infection also has a slightly different view, see attached file "main-bad status.png"

macro-good status
macro-bad status
main-bad status

@ArkadiuszMichalski
Copy link
Contributor

I can't reproduce this, at least in the standard theme in system.
image

@artie-finkelstein
Copy link
Author

artie-finkelstein commented Aug 11, 2021 via email

@Yaron10
Copy link

Yaron10 commented Aug 12, 2021

STR (Steps To Reproduce):

Open the "Shortcut Mapper".
Resize the window vertically from the bottom.

Result:

At some point, the status is not fully visible.
(Both Win 7 and Win 10).

תמונה


@artie-finkelstein,

I'm also using the Classic Theme on Win 7.

I understand you encounter the problem without resizing.
Can you please list your exact STR with a fresh portable NPP?

@artie-finkelstein
Copy link
Author

artie-finkelstein commented Aug 12, 2021 via email

@mere-human
Copy link
Contributor

I was able to reproduce the issue using these steps:

Open the "Shortcut Mapper".
Resize the window vertically from the bottom.

After resize:
image

Sometimes looks good:
image

I'm not sure if it's the same issue or not.

Notepad++ v8.1.2   (32-bit)
Build time : Aug  1 2021 - 16:44:44
Path : ...\notepad++.exe
Command Line : 
Admin mode : OFF
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 10 Enterprise (64-bit) 
OS Version : 2009
OS Build : 19043.1110
Current ANSI codepage : 1252
Plugins : none

@Yaron10
Copy link

Yaron10 commented Aug 12, 2021

@mere-human,

Thank you for confirming.
This issue is reproducible with older NPP vesions.

@artie-finkelstein,

Thank you.

I can reproduce your issue on Win 7 with Windows Classic Theme.
The cause is commit 934c988.

@artie-finkelstein
Copy link
Author

artie-finkelstein commented Aug 12, 2021 via email

@ozone10
Copy link
Contributor

ozone10 commented Aug 13, 2021

This seems to be issue with resizing "babygrid"

take a note of these comments

//This function needs a static placement position inside a parent window (default in Npp).
//For a dynamic position (e.g. sizing of the parenet window) an adjustment to this function is needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants