Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPPM_RELOADFILE long filename issue #11106

Closed
chcg opened this issue Jan 30, 2022 · 1 comment
Closed

NPPM_RELOADFILE long filename issue #11106

chcg opened this issue Jan 30, 2022 · 1 comment
Assignees

Comments

@chcg
Copy link
Contributor

chcg commented Jan 30, 2022

Description of the Issue

Usage of NPPM_RELOADFILE from pythonscript by test case https://github.com/bruderstein/PythonScript/blob/master/PythonScript/python_tests/tests/NotepadWrapperTestCase.py#L383-L397 with a 8.3 notation of the file path shows an issue that the file is not found by N++. Introduced from the very beginning with:

Revision: 5529852
Author: harrybharry harrybharry@f5eea248-9336-0410-98b8-ebc06183d4e3
Date: 16.06.2008 13:35:05
Message:
Fix file case problem.
Fix incremental search not using selected text.
Fix Session not loaded using anything other than file->open menu.

git-svn-id: svn://svn.tuxfamily.org/svnroot/notepadplus/repository@235 f5eea248-9336-0410-98b8-ebc06183d4e3

Modified: PowerEditor/src/Notepad_plus.cpp
Modified: PowerEditor/src/ScitillaComponent/Buffer.cpp
Modified: PowerEditor/src/lastRecentFileList.cpp

Steps to Reproduce the Issue

  1. Call NPPM_RELOADFILE with a filename containing 8.3 notation, e.g. C:\longnamedir aka C:\longna~1

Expected Behavior

  • File reloaded

Actual Behavior

  • File not reloaded

Debug Information

Notepad++ v8.2.1 (64-bit)
Build time : Jan 30 2022 - 00:24:07
Path : C:\Users\christian\Source\Repos\npp.8.2.portable.x64\notepad++.exe
Command Line :
Admin mode : OFF
Local Conf mode : ON
Cloud Config : OFF
OS Name : Windows 10 Home (64-bit)
OS Version : 2009
OS Build : 19044.1503
Current ANSI codepage : 1252
Plugins : HexEditor.dll Papyrus.dll PythonScript.dll

@chcg chcg added bug enhancement Proposed enhancements of existing features and removed enhancement Proposed enhancements of existing features labels Jan 30, 2022
@donho donho added the accepted label Feb 4, 2022
@donho donho closed this as completed in c0be504 Feb 4, 2022
@donho
Copy link
Member

donho commented Feb 16, 2022

PR #11107 causes the regression #11215.
So this issue is reopened.

@donho donho reopened this Feb 16, 2022
@donho donho closed this as completed in 51b1c93 Feb 16, 2022
chcg added a commit to bruderstein/PythonScript that referenced this issue Oct 28, 2022
…ith notepad-plus-plus/notepad-plus-plus#11106

- added assert checks to testcases for the new methods with bool return values
- removed not implemented declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants